Generate favicons via multi-node logo read, not single-node exists()

FixSecurityService
Shipped
June 30, 2026 at 10:47 PM UTC
Author
Kamo
Commit
c484155

generateAndUploadFavicons() gated on minioService.exists(), which only stats the current MinIO host. When the simple logo was written to (or only replicated onto) a different node, exists() returns a false NoSuchKey and favicon generation silently early-returned — leaving config.json, globals.css and site.webmanifest written but no favicon images (e.g. optionone-com had img/logo.svg present yet an empty favicon/ set, no error logged). download() already does multi-node failover, so read the logo directly and only skip when it is genuinely absent on every node.

All changes

Like what you see shipping?

Every one of these updates lands in your workspace automatically. Start free and watch it grow week after week.

Start Free ForeverView Pricing