Purge VIEW_EMAIL_LOGS rows, and stop a test rotting when ordinals shift

FeatureInitializerService
Shipped
August 15, 2026 at 5:22 AM UTC
Author
Kamo
Commit
a643b36

VIEW_EMAIL_LOGS (64) was deleted from RoleRightType today for naming a feature that was never built. This removes what it left behind — measured at 42 role rows, 33 applied rows and 8 template rows — across both encodings, since the template table stores the enum NAME while the rest store the integer id. **************** needed fixing in the same change, and the reason is worth keeping. It asserted its example right had id != ordinal, guarded by "test is only meaningful while" that holds. Removing id 64 shifted every later ordinal, **************** id became equal to its ordinal, and the guard fired. Had the guard not been there the test would have kept passing while proving nothing, which is the worse outcome. It now picks its witness at runtime — any right that has an ancestor and whose id differs from its ordinal — so no future deletion can quietly hollow it out. Deleting rights is now routine enough that a hardcoded example is a liability.

All changes

Like what you see shipping?

Every one of these updates lands in your workspace automatically. Start free and watch it grow week after week.

Start Free ForeverView Pricing