Stop handing an alias row over as the org's domain

FixESigService
Shipped
August 24, 2026 at 9:38 PM UTC
Author
Kamo
Commit
9400b83

**************** walked org.getDomains() filtering only on isActive. That collection holds the org's root domain AND its alias rows -- api, login, theme and the rest -- in the same table, and an alias row stores a bare label rather than a hostname. So the method could return "login" as an organization's FQDN. What that builds is https://sign.login/... in a signing link and **************** for the logo: addresses that resolve nowhere, in an email to an external counterparty who is not going to report it. There is no @OrderBy on the collection, so whether it happened came down to the order the database returned rows in. Skipping rows with a parent fixes it. An org whose only rows are aliases now resolves to null, which the caller already handles -- a bare label silently builds a URL that cannot resolve, so null is the better answer. Noted while auditing this file: SignLinkBuilder's sign.sign.pink fallback is NOT a defect and is left alone. sign.pink is a Kamo-owned organization (id 1174321970511380486, DNS-verified) and its own test pins the fallback as intended behaviour. 149 tests pass.

All changes

Like what you see shipping?

Every one of these updates lands in your workspace automatically. Start free and watch it grow week after week.

Start Free ForeverView Pricing