The Favourites header must control an element that exists

Fixkamo-internal
Shipped
August 30, 2026 at 2:54 AM UTC
Author
Kamo
Commit
7b86047

Collapsing the section unmounted the list it named through `aria-controls`, leaving the header pointing at nothing. `aria-expanded` then describes a disclosure with no disclosed element, which is precisely the case assistive technology has nothing to announce for. Hidden rather than unmounted — the standard disclosure shape — and the tests now assert what the member actually experiences (the section is hidden) rather than an implementation detail that happened to coincide with it (the rows are gone from the DOM). The cost is a handful of mounted rows nobody can see; the section is a member's own starred conversations, capped server-side at 200 and in practice a few.

All changes

Like what you see shipping?

Every one of these updates lands in your workspace automatically. Start free and watch it grow week after week.

Start Free ForeverView Pricing